ci: disable ccache by default #2697
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tido64
reviewed
Sep 19, 2025
| - name: Set up Ccache | ||
| id: setup-ccache | ||
| if: ${{ inputs.platform == 'ios' || inputs.platform == 'macos' || inputs.platform == 'visionos' }} | ||
| if: ${{ (inputs.platform == 'ios' || inputs.platform == 'macos' || inputs.platform == 'visionos') && inputs.enable-ccache == 'true' }} |
There was a problem hiding this comment.
The lint job is still failing and this path does not run unless you specify platform, which the lint job does not.
There was a problem hiding this comment.
Yeah. Looks like my assumption was false. I'll mark as a draft meanwhile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I'm not sure we have cache properly set up, and cache issues consistently cause the first run of the "Lint PR title" job to fail. Let's disable cache by default on CI.
Test Plan:
CI should pass